Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated timeouts #132

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Updated timeouts #132

merged 1 commit into from
Jul 27, 2023

Conversation

cynicaljoy
Copy link
Contributor

Ticket(s): BT-3922

Problem

  1. Consumers are unable to specify their own timeout settings
  2. We should be setting a default Query Timeout & Client Buffer Timeout

Solution

  • Timeouts can optionally be set when initializing a new client
  • Set defaults for Query and Client Buffer Timeouts

Result

  • Improved defaults
  • Consumers can override settings as desired

Testing

Basic local testing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cynicaljoy cynicaljoy force-pushed the BT-3922-httpx-timeouts branch from 847ce15 to 298303a Compare July 26, 2023 18:28
@cynicaljoy cynicaljoy requested a review from pnwpedro July 26, 2023 18:34
@cynicaljoy
Copy link
Contributor Author

this should remediate #122

@cynicaljoy cynicaljoy merged commit 56a66d6 into main Jul 27, 2023
@cynicaljoy cynicaljoy deleted the BT-3922-httpx-timeouts branch July 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnwpedro pnwpedro pnwpedro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cynicaljoy @pnwpedro