Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry on transport errors #139

Merged
merged 1 commit into from
Aug 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions fauna/http/httpx_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,27 @@ def request(
except httpx.InvalidURL as e:
raise ClientError("Invalid URL Format") from e

try:
return HTTPXResponse(self._send_with_retry(3, request))
except (httpx.HTTPError, httpx.InvalidURL) as e:
raise NetworkError("Exception re-raised from HTTP request") from e

def _send_with_retry(
self,
retryCount: int,
request: httpx.Request,
) -> httpx.Response:
try:
response = self._c.send(
request,
stream=False,
)
except (httpx.HTTPError, httpx.InvalidURL) as e:
raise NetworkError("Exception re-raised from HTTP request") from e

return HTTPXResponse(response)
return response
except httpx.TransportError as e:
if retryCount == 0:
raise e
else:
return self._send_with_retry(retryCount - 1, request)
sprsquish marked this conversation as resolved.
Show resolved Hide resolved

def stream(
self,
Expand Down