BT-4723: Query limits tests are failing due to uncaught ThrottlingError #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnwpedro
previously approved these changes
Mar 5, 2024
adambollen
changed the title
pnwpedro
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): BT-4723
Problem
Query limit tests are failing in pipeline.
Solution
The tests run by hitting the db with multiple read queries in parallel, but expects that at least one of those clients will succeed on retry, but an uncaught ThrottlingError blows the whole thing up. Catching and ignoring the error lets at least one client pass on retry.
Result
Test is now passing locally.
Testing
Ran the test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.