Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
Regarding HTTP 1.1., the h2 library has a bug that mishandles the HTTP2 protocol for GOAWAY frames. When it receives a GOAWAY, in progress streams are not allowed to complete. This means any time our edge issues a GOAWAY an in progress request will throw even if Fauna handled it correctly.
The automatic retry was causing the client to resend the query. This is an unsafe retry because the client doesn't know whether Fauna ran the query.
How was the change tested?
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.