Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-6679: Introduce support for changefeeds #192

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

erickpintor
Copy link
Contributor

Description

Add changefeeds support to the Python driver.

Motivation and context

Changefeeds allows to interactively poll from a stream instead of having it open at all times. It's useful for cron jobs and other forms of periodic tasks to sync 3rd party systems.

How was the change tested?

Unit tests are included.

Screenshots (if appropriate):

NA

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@erickpintor erickpintor changed the title ENG-6679: Introduce support for change feeds ENG-6679: Introduce support for changefeeds Sep 19, 2024
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README looks good aside from some minor nits. I'll work on getting the docs.fauna.com docs ready.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fauna/client/client.py Show resolved Hide resolved
fauna/client/client.py Outdated Show resolved Hide resolved
fauna/client/client.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ptpaterson ptpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my code comments are resolved. I'm not certain what you would consider the new, idiomatic error handling on the user side.

README.md Outdated Show resolved Hide resolved
@ptpaterson ptpaterson requested a review from jrodewig September 24, 2024 15:55
@erickpintor
Copy link
Contributor Author

I'm not certain what you would consider the new, idiomatic error handling on the user side.

We can gather feedback from python folks during the python bug bash this Friday.

@erickpintor erickpintor force-pushed the changefeeds branch 3 times, most recently from cdc7e75 to 04f9ccd Compare September 26, 2024 14:34
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ptpaterson
ptpaterson previously approved these changes Sep 30, 2024
@erickpintor
Copy link
Contributor Author

I'll need another 🐑. I've marked the feature as beta in the readme file.

jrodewig
jrodewig previously approved these changes Oct 1, 2024
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it.

README.md Outdated Show resolved Hide resolved
pnwpedro
pnwpedro previously approved these changes Oct 2, 2024
@erickpintor erickpintor enabled auto-merge (squash) October 2, 2024 16:23
@erickpintor erickpintor disabled auto-merge October 2, 2024 16:24
Co-authored-by: James Rodewig <james.rodewig@fauna.com>
@erickpintor erickpintor merged commit ea787b9 into main Oct 2, 2024
7 checks passed
@erickpintor erickpintor deleted the changefeeds branch October 2, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants