-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CDC terms #201
Rename CDC terms #201
Conversation
25f7b85
to
4bfff78
Compare
FYI: This is ready for a code review but tests will fail until the next docker release is out some time later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @cynicaljoy. Let's improve that a little bit. Suggestion included. Otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good overall! Left some minor nits and feedback.
Not sure if it fits in this PR, but something I just came across while doing event feeds for JVM is that we have a lot of classes with Query in the name that we might want to rename. Things like |
I'd consider that a separate effort. |
4bfff78
to
c238aad
Compare
This is ready for another pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from a minor fix in the README. Thanks!
c238aad
to
20dc828
Compare
Description
This patch renames CDC terms according to our new guidelines.
Motivation and context
.change_feed(..)
becomes.feed(..)
ChangeFeed{Options,Iterator,Page}
becomesFeed{Options,Iterator,Page}
Old terms related to streaming are deprecated and should be removed in the next major version. Old terms related to event feeds were ripped off.
How was the change tested?
Unit tests included.
Screenshots (if appropriate):
NA.
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.