Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise.done is deprecated. #15

Closed
nvaken opened this issue Aug 16, 2016 · 7 comments
Closed

Promise.done is deprecated. #15

nvaken opened this issue Aug 16, 2016 · 7 comments
Assignees

Comments

@nvaken
Copy link

nvaken commented Aug 16, 2016

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1143:5)
Object.activate (/Users/nvaken/.atom/dev/packages/drupal/lib/drupal.coffee:6:22)
Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26)
@robballou
Copy link
Contributor

Which version of Atom does this affect?

@nvaken
Copy link
Author

nvaken commented Aug 17, 2016

That would be 1.9.8

@robballou
Copy link
Contributor

I didn't get the warning myself, but I have applied a fix in the master branch if you want to test it out.

Thanks!

@nvaken
Copy link
Author

nvaken commented Aug 17, 2016

I'm not sure when this was triggered, just saw it this one time. Since I'm unable to reproduce, I'll close it for now, fix seems legit to me.

@nvaken nvaken closed this as completed Aug 17, 2016
@jeffgeorge
Copy link

@robballou I'm seeing this same warning in the Deprecation Cop in Atom 1.13.0-beta8. Can you please tag a new release with this fix included?

@robballou
Copy link
Contributor

I don't think I can make new releases via APM, etc., but have tagged @michaelfavia who can.

@michaelfavia
Copy link
Member

michaelfavia commented Dec 13, 2016

Release rolled and published. Testing it now. Thanks @robballou and @jeffgeorge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants