-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise.done is deprecated. #15
Comments
Which version of Atom does this affect? |
That would be |
I didn't get the warning myself, but I have applied a fix in the master branch if you want to test it out. Thanks! |
I'm not sure when this was triggered, just saw it this one time. Since I'm unable to reproduce, I'll close it for now, fix seems legit to me. |
@robballou I'm seeing this same warning in the Deprecation Cop in Atom 1.13.0-beta8. Can you please tag a new release with this fix included? |
I don't think I can make new releases via APM, etc., but have tagged @michaelfavia who can. |
Release rolled and published. Testing it now. Thanks @robballou and @jeffgeorge! |
Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done
The text was updated successfully, but these errors were encountered: