Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fetch-depth to streamline tag fetching #124

Closed
wants to merge 1 commit into from

Conversation

favonia
Copy link
Owner

@favonia favonia commented Mar 13, 2022

This is to track whether actions/checkout#290 is fixed so that we can drop the hack to fetch all tags. This PR should not be merged until the issue has been resolved.

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #124 (4058589) into main (4d2051c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files          25       25           
  Lines        1256     1256           
=======================================
  Hits          997      997           
  Misses        255      255           
  Partials        4        4           
Flag Coverage Δ
unittests 79.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@favonia favonia marked this pull request as draft March 13, 2022 14:18
@favonia favonia force-pushed the main branch 2 times, most recently from 345fe12 to d5f434a Compare March 20, 2022 15:17
@favonia
Copy link
Owner Author

favonia commented May 9, 2022

Close this for now.

@favonia favonia closed this May 9, 2022
@favonia favonia deleted the streamline-fetch-tags branch May 9, 2022 13:51
@Grogogoll
Copy link

Workflow runs completed with no jobs

@favonia
Copy link
Owner Author

favonia commented Oct 21, 2023

@Grogogoll Hi, could you possibly explain a bit more? I have trouble understanding your comment. Did you mean that the PR actually worked? This is an old PR, so maybe not all the records are available now.

@Grogogoll
Copy link

Oups, sorry about that, I guess I made some mistake here. Well I should watch out...

@favonia
Copy link
Owner Author

favonia commented Oct 24, 2023

@Grogogoll That's fine. Let me know if you notice other issues. Unfortunately I think it's still necessary to git fetch everything to calculate the correct version. (This is about an optimization of the CI process and should not affect how efficient the eventually built updater is, so... it's just that GitHub will spend more time building the artifacts 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants