Apply import rules to moved assets. #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Haruma-K, Thanks for bringing this into my attention. I'm surprised that the current implementation can not handle moved assets. I will do a few tests, but may take some time. |
|
Thanks for the reply, @favoyang . Oh, so the behavior was different from what you thought. |
|
I have some tests and you're right about the behaviors.
I will read your PR carefully and get back to you. |
favoyang
requested changes
Apr 25, 2020
favoyang
approved these changes
Apr 26, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2020
# [0.6.0](v0.5.4...v0.6.0) (2020-04-26) ### Features * handle moved assets (close: [#20](#20)) ([a902a21](a902a21))
|
🎉 This issue has been resolved in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@Haruma-K Thank you! This PR is awesome. I've added your name to the README as a contributor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the import rules to be applied to moved assets as well.
Also, delete the entry if there are no rules to apply as a result of the move.