Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select UK English #16

Merged
merged 7 commits into from
Jul 5, 2021
Merged

Select UK English #16

merged 7 commits into from
Jul 5, 2021

Conversation

pierreminiggio
Copy link
Contributor

@pierreminiggio pierreminiggio commented Jul 5, 2021 •
edited
Loading

Hello !
The login form is now forced in english.
BUT :

  • After loging in, we're back to the awesome French world again, so we'll have to handle lang selection here too... :'(
  • Couldn't find a way to get rid of my 2 waitForTimeout

Update 06/07/2021 00:54 :

  • Got the 2nd Select working, and the video uploading process completes. But now the video links I get in return are bad :
    image
    Seems unrelated to my changes, it shows an incomplete link when the processing isn't done yet
    image

Update 06/07/2021 01:09 :
image
Fixed it with a simple do While

So it's now working on my french chromium.

The way I implemented is likely not french dependant, so it may work for other languages as well.

This change is Reviewable

@pierreminiggio pierreminiggio mentioned this pull request Jul 5, 2021
Closed
@pierreminiggio pierreminiggio changed the title Select UK English before loging in Select UK English Jul 5, 2021
@fawazahmed0 fawazahmed0 merged commit 6fc4114 into fawazahmed0:main Jul 5, 2021
@fawazahmed0
Copy link
Owner

fawazahmed0 commented Jul 5, 2021 •
edited
Loading

I tested it and it works fine, thank you so much for the PR 👍

@pierreminiggio pierreminiggio mentioned this pull request Jul 13, 2021
Closed
@pierreminiggio pierreminiggio deleted the handle-lang-selectors branch August 31, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierreminiggio @fawazahmed0