improvement: close browser before throwing error

[ClassAxion]

We should catch errors then close browser and throw the error because otherwise people like me who have this script in loop with own error handling will have memory leak because old browser stays in background.

Please check before mergeing.

[pierreminiggio]

In some other parts of the code, we already have checks for some errors that will kill the browser before throwing again.
But can't hurt to have another checker higher in the loop like you added to make up for the other errors that aren't caught.
I've one question though : what does browser.close() does if the browser happens to be already closed ?

[ClassAxion]

Ok, I didn't know about it. So browser.close() in catch should probably be in individual try ... catch
Sometimes I have internet problems so I've got Navigation timeout and then the browser doesn't close.

[fawazahmed0]

what does browser.close() does if the browser happens to be already closed ?

It doesn't do anything

import puppeteer from 'puppeteer';

(async () => {
  const browser = await puppeteer.launch({headless:false});
  await browser.close();
  await browser.close();

  console.log('hi')
})();

Output:

hi

[fawazahmed0]

Thanks for PR