Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quoted attributes regex fix #17

Merged
merged 3 commits into from
Jan 20, 2018
Merged

Quoted attributes regex fix #17

merged 3 commits into from
Jan 20, 2018

Conversation

jspri
Copy link
Contributor

@jspri jspri commented Aug 31, 2016

Allows newlines \n to be inside quoted attribute values e.g. [value="\nsomething"]. Test included.

@fb55
Copy link
Owner

fb55 commented Sep 6, 2016 •
edited
Loading

I didn't know that . didn't include newlines, thanks for the PR! I would prefer [^] over [\w\W] — what do you think?

@jspri
Copy link
Contributor Author

jspri commented Sep 7, 2016

I agree! Should be good to go :)

@fb55 fb55 merged commit 2e83211 into fb55:master Jan 20, 2018
@fb55
Copy link
Owner

fb55 commented Jan 20, 2018

Whee, sorry for the delay. Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jspri @fb55