Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parse): Hand-roll attribute parsing #503

Merged
merged 1 commit into from
May 28, 2021
Merged

fix(parse): Hand-roll attribute parsing #503

merged 1 commit into from
May 28, 2021

Conversation

fb55
Copy link
Owner

@fb55 fb55 commented May 28, 2021

Attribute values are slightly more permissive now.

Ensures attribute parsing will always be linear.

Attribute values are slightly more permissive now.

Ensures attribute parsing will always be linear.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 46b0dbd on fix/attr into 0d6190c on master.

@fb55 fb55 merged commit 4cdaacf into master May 28, 2021
@fb55 fb55 deleted the fix/attr branch May 28, 2021 18:29
@SymbioticKilla
Copy link

@fb55 Do you plan release 4.0.1 version with this fix?
Thanks!

@fb55
Copy link
Owner Author

fb55 commented Jun 7, 2021

There is a 5.0.1 release with this fix out already. 5.0.0 implemented the default HTML spec behavior for ignoreCase (which technically is a breaking change, but very likely a wanted one) and should be safe to upgrade to in any case.

@SymbioticKilla
Copy link

SymbioticKilla commented Jun 7, 2021

@fb55 Thank you for the answer! The problem is in build-angular. Should I ask svgo developers?
-- @angular-devkit/build-angular@0.1102.14
-- cssnano@5.0.2
-- cssnano-preset-default@5.1.2
-- postcss-svgo@5.0.2
-- svgo@2.3.0
-- css-select@3.1.2
-- css-what@4.0.0

@fb55
Copy link
Owner Author

fb55 commented Jun 7, 2021

That seems like the best way forward, yes. I know that it is annoying to get everyone to update their versions, best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants