Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(decode): Add EntityDecoder class #1136

Merged
merged 30 commits into from
Apr 12, 2023
Merged

feat(decode): Add EntityDecoder class #1136

merged 30 commits into from
Apr 12, 2023

Conversation

fb55
Copy link
Owner

@fb55 fb55 commented Apr 5, 2023 •
edited
Loading

This class can be used by parsers that rely on entities to elegantly parse chunked entities (eg. from streams). Also adds support for parsing HTML entities in attributes.

fb55 added 30 commits March 27, 2023 21:49
@fb55
feat: Add EntityDecoder class
d90eade
@fb55
Add comments
f82785d
@fb55
Rename reset to startEntity, move isAttribute
ac1ebf7
@fb55
Update indices
6fb8f25
@fb55
Update decode.ts
832bf9d
@fb55
Add EntityDecoderMode
02af4c8
@fb55
Fix numeric entities
cfb8239
@fb55
Emit code points instead of strings
71b6867
@fb55
Add this.treeCurrent
1c69162
@fb55
Merge codepoint and resultIdx
f19a8a4
@fb55
Add consumed to callback
7dac658
@fb55
Add tests from htmlparser2
3593b3b
@fb55
Remove unnecessary this.treeCurrent
96f320b
@fb55
Support attribute decoding mode
0731486 
Will only allow endings as specific in the HTML spec
@fb55
Simplify named entity data emission
3d9c577
@fb55
s/treeIdx/treeIndex
bd1af64
@fb55
s/strIdx/offset
1a1b373
@fb55
s/lastIdx/lastIndex
de6b9f5
@fb55
Remove TODO
b93c7af
@fb55
Add entity error handling
7b3a210
@fb55
Add more tests, docs
ac06454
@fb55
Keep the DecodingMode enum
36f8645
@fb55
Simplify level & mode handling
b49cf05
@fb55
Fix entities in attributes followed by letters
9c3ed1b
@fb55
Emit second code points with consumed=0
726e9f9
@fb55
Change order of errors
308e84c
@fb55
Revert "Emit second code points with consumed=0"
ec5e9c6 
This reverts commit 726e9f9.
@fb55
Add consumed count to absenceOfDigitsInNumericCharacterReference
aef3927 
We don't emit an entity, so we need a location for the error.
@fb55
Improve test coverage
39bf309
@fb55
Document functions
f1bf302
@fb55 fb55 merged commit 06dc638 into master Apr 12, 2023
@fb55 fb55 deleted the entity-decoder branch April 12, 2023 10:24
@fb55 fb55 mentioned this pull request Apr 13, 2023
Merged
@hakatashi hakatashi mentioned this pull request Jul 18, 2024
Merged
@fb55 fb55 restored the entity-decoder branch December 22, 2024 18:14
@fb55 fb55 deleted the entity-decoder branch December 22, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fb55