Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startIndex not updated after a self-closing XML tag #941

Closed
thewilkybarkid opened this issue Sep 4, 2021 · 1 comment · Fixed by #949
Closed

startIndex not updated after a self-closing XML tag #941

thewilkybarkid opened this issue Sep 4, 2021 · 1 comment · Fixed by #949

Comments

@thewilkybarkid
Copy link

After debugging parcel-bundler/parcel#6752 (comment), the following XML:

<xml><a/><b/></xml>

gives the same startIndex on theb openTag event as it did for the a openTag (5, rather than the expected 9).
@thewilkybarkid thewilkybarkid mentioned this issue Sep 4, 2021
Merged
3 tasks
fb55 added a commit that referenced this issue Sep 11, 2021
@fb55
fix(parser): Fix indices of self-closing tags in XML
fee0a88 
Fixes #941
@fb55 fb55 mentioned this issue Sep 11, 2021
Merged
@fb55 fb55 closed this as completed in #949 Sep 11, 2021
@fb55
Copy link
Owner

fb55 commented Sep 11, 2021

Thanks for the report! Fixed this in #949 and released as 7.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(parser): Fix indices of self-closing tags in XML fb55/htmlparser2
2 participants
@fb55 @thewilkybarkid