[tokenizer] fix case where < followed by whitespace doesn't parse
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb55
added a commit
that referenced
this pull request
Jul 20, 2013
[tokenizer] fix case where `<` followed by whitespace doesn't parse
|
Thanks! |
|
@fb55 Can you release a new version with this fix? |
|
Published as 3.1.5. |
fb55
added a commit
that referenced
this pull request
Jul 21, 2013
|
Online demo also updated 😄 http://htmlparser.forbeslindesay.co.uk/ |
|
@ForbesLindesay Couldn't that be automated by using jesusabdullah/browserify-cdn / http://wzrd.in.nyud.net/? |
|
It could be, but that adds mmore moving parts. This way it generates one single minified browserify bundle, which is nice and efficient. I also display the version number that's been loaded on the page, which may be tricky to do via the browserify-cdn as things currently stand. Also, deploying is just a case of updaing the "htmlparser2" version in package.json, testing if I feel like it, and typing |
fb55
added a commit
that referenced
this pull request
Oct 21, 2018
[tokenizer] fix case where `<` followed by whitespace doesn't parse
fb55
added a commit
that referenced
this pull request
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you parse the string
'a < b'everything after the<is lost (result:'a '). Whereas other parsers, (chrome and firefox) the result is'a < b'Causing this bug on jsdom: jsdom/jsdom#652