Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to set "class" in cleanAttributes #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allows to set "class" in cleanAttributes #50

wants to merge 1 commit into from

Conversation

anthony-foulfoin
Copy link

For being able to display properly the twitter widget in parsed articles, I need to set the class attribute of the blockquote as "clean", because the widget use it to know if it should display a twitter widget for the blockquote or not, for instance:

<blockquote class="twitter-tweet">
... 
</blockquote>

But even if i add "class" in "cleanAttributes" or if I disable the cleanAttribute setting the classes continue to be wiped because there is an earlier condition in the if block :

	else if(name === "id" || name === "class"){

So if the attribute is named class it cannot be evaluated as a clean attribute or not, this PR fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant