Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACSC rule is checking the wrong baseline for Windows Update #305

Closed
flobroeder opened this issue Mar 13, 2023 · 6 comments
Closed

ACSC rule is checking the wrong baseline for Windows Update #305

flobroeder opened this issue Mar 13, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request patch Includes bug fixes, focusing on enhancing stability.
Milestone

Comments

@flobroeder
Copy link
Contributor

Please review ACSC rules for Windows update - these rules seem to check the wrong place in registry or there are more configuration places?

Windows system reality

image

AuditTAP:
image

@flobroeder flobroeder added the enhancement New feature or request label Mar 13, 2023
@flobroeder flobroeder added this to the 5.5 milestone Mar 15, 2023
@SteffenWinternheimer
Copy link
Collaborator

SteffenWinternheimer commented Mar 15, 2023

If setting is set throughout the GUI, it seems like it cannot get checked throughout the registry path. Currently we have no workaround for that.
If this setting is set via registry, then it can also be checked via registry.

Will be set back to a later release.

@SteffenWinternheimer SteffenWinternheimer removed this from the 5.5 milestone Mar 15, 2023
@TuemmlerKelch
Copy link
Collaborator

Please refer to this article for improved checks

@SteffenWinternheimer SteffenWinternheimer added this to the 5.7.1 milestone Nov 20, 2023
@TuemmlerKelch TuemmlerKelch changed the title ACSC rule is checking the wrong baseline for WIndows Update ACSC rule is checking the wrong baseline for Windows Update Dec 4, 2023
@TuemmlerKelch TuemmlerKelch modified the milestones: 5.7.1, 5.7.2 Dec 4, 2023
@SteffenWinternheimer SteffenWinternheimer added the patch Includes bug fixes, focusing on enhancing stability. label Dec 14, 2023
@SteffenWinternheimer
Copy link
Collaborator

SteffenWinternheimer commented Jan 15, 2024

I am not sure, which AuditRules should be replaced with the ones, provided in the link. Also i took a look again at the benchmark from ACSC, here are the rules provided by them:
grafik
This is the link to the admx.help page
https://admx.help/?Category=Windows_10_2016&Policy=Microsoft.Policies.WindowsUpdate::AutoUpdateCfg

Let's discuss about this ticket again @TuemmlerKelch

@TuemmlerKelch
Copy link
Collaborator

TuemmlerKelch commented Jan 16, 2024

As discussed, the focus lies on the one setting we refer to as High-049 D. Implementation is described in the article in my above comment.
Due to the fact that the configuration is different for manual setting and setting via group policy, we need more complex approach.
manual setting:
(
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Services]
"DefaultService"="7971f918-a847-4430-9279-4a52d1efe18d"
AND
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Services\7971F918-A847-4430-9279-4A52D1EFE18D]
"RegisteredWithAU"=dword:00000001
)
OR
[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\WindowsUpdate\AU]
"AllowMUUpdateService"=dword:00000001
"NoAutoUpdate"=dword:00000000

Please make sure to check other benchmarks, too.

@SteffenWinternheimer
Copy link
Collaborator

TODO: Update logic, add try catch

@SteffenWinternheimer
Copy link
Collaborator

try-catch added, waiting for approval of pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch Includes bug fixes, focusing on enhancing stability.
Projects
None yet
Development

No branches or pull requests

3 participants