Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WinRM dependencies that came from adding PowerShell 7 compatibility #423

Closed
TuemmlerKelch opened this issue Oct 16, 2023 · 1 comment · Fixed by #424
Closed

Remove WinRM dependencies that came from adding PowerShell 7 compatibility #423

TuemmlerKelch opened this issue Oct 16, 2023 · 1 comment · Fixed by #424
Assignees
@qngngyn
Labels
critical This needs to be fixed asap
Milestone
5.6.2

Comments

@TuemmlerKelch
Copy link
Collaborator

TuemmlerKelch commented Oct 16, 2023 •
edited
Loading

With #405 we addressed an issue where Get-WMIObject was not compatible with PowerShell 7 and thus switched to Get-CimInstance.
This introduced a new issue, requiring WinRM being active on the client. To get rid of WinRM-dependency, PowerShell7 is now officially not supported.

Check if it is PS7 and present an information that PS5 is to be used. The user will be able to switch from PS7 to PS5 by entering Start Powershell

Make sure to state PowerShell Version support in readme.md and revert the changes back to Get-WMIObject usage
@TuemmlerKelch TuemmlerKelch added the critical This needs to be fixed asap label Oct 16, 2023
@TuemmlerKelch TuemmlerKelch added this to the 5.7 milestone Oct 16, 2023
@TuemmlerKelch TuemmlerKelch changed the title Implement check for PowerShell 7, as various cmdlets are not compatible with PS7 Remove WinRM dependencies that came from adding PowerShell 7 compatibility Oct 16, 2023
@TuemmlerKelch
Copy link
Collaborator Author

Issue created with #405

@TuemmlerKelch TuemmlerKelch modified the milestones: 5.7, 5.6.2 Oct 16, 2023
qngngyn added a commit that referenced this issue Oct 18, 2023
@qngngyn
#423: Added powershell check and handling
1e45637
qngngyn added a commit that referenced this issue Oct 18, 2023
@qngngyn
#423: README update
1729098
@qngngyn qngngyn mentioned this issue Oct 18, 2023
Merged
@qngngyn qngngyn linked a pull request Oct 18, 2023 that will close this issue
Ticket 423 #424
Merged
@TuemmlerKelch TuemmlerKelch mentioned this issue Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qngngyn qngngyn

Labels
critical This needs to be fixed asap
Projects
None yet
Milestone
5.6.2
Development

Successfully merging a pull request may close this issue.

Ticket 423 fbprogmbh/Audit-Test-Automation
3 participants
@SteffenWinternheimer @TuemmlerKelch @qngngyn