Skip to content

Commit

Permalink
aerospikereceiver: Add missing units in metadata.yaml (open-telemetry…
Browse files Browse the repository at this point in the history
…#23572)

Metric unit is required, see:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/mdatagen/metadata-schema.yaml#L72-L73.

This PR adds the unit to metrics where this is missing:

- aerospike.node.query.tracked
  • Loading branch information
mackjmr authored and fchikwekwe committed Jun 23, 2023
1 parent 81b85ee commit 853e91a
Show file tree
Hide file tree
Showing 6 changed files with 341 additions and 318 deletions.
22 changes: 22 additions & 0 deletions .chloggen/add-units-aerospikereceiver.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Use this changelog template to create an entry for release notes.
# If your change doesn't affect end users, such as a test fix or a tooling change,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: aerospikereceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Adds unit to metrics where this was missing.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [23572]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
Affected metrics can be found below.
- aerospike.node.query.tracked
2 changes: 1 addition & 1 deletion receiver/aerospikereceiver/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ Number of queries which ran more than query untracked_time (default 1 sec), Aero
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
| ---- | ----------- | ---------- | ----------------------- | --------- |
| | Sum | Int | Cumulative | true |
| {queries} | Sum | Int | Cumulative | true |
## Resource Attributes
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions receiver/aerospikereceiver/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ metrics:
enabled: true
description: Number of queries tracked by the system.
extended_documentation: Number of queries which ran more than query untracked_time (default 1 sec), Aerospike metric query_tracked
unit: '{queries}'
sum:
value_type: int
input_type: string
Expand Down
Loading

0 comments on commit 853e91a

Please sign in to comment.