Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make boost::filesystem optional #81

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

eagleoflqj
Copy link
Member

Intent: on macOS enable tools but exclude migrators; on iOS disable them all.

@wengxt
Copy link
Member

wengxt commented Nov 16, 2024

boost filesystem is suppose to be optional if std::filesystem is available.

There might be some issue on the GNUC <= 8 condition when build against clang, can you help fix that instead?

basically, libstdc++ in gcc 7 doesn't have usable std::filesystem

@eagleoflqj
Copy link
Member Author

Wouldn't it be preferable to remove migration tools? After all fcitx4 was archived, and old versions of libime can always do the one-time job.

@wengxt
Copy link
Member

wengxt commented Nov 16, 2024

Wouldn't it be preferable to remove migration tools? After all fcitx4 was archived, and old versions of libime can always do the one-time job.

Well, some people may have random binary files available on internet so it could still be useful. I have no plan to remove them anytime soon.

@wengxt
Copy link
Member

wengxt commented Nov 16, 2024

If you need an example on std::filesystem detection, here's something I found on internet https://github.com/ccache/ccache/pull/1190/files

@wengxt
Copy link
Member

wengxt commented Nov 16, 2024

Basically what in my mind is, run a CheckCXXSourceCompiles against the API that we use (there's only one), if fail, then fallback to boost filesytem. I believe whatever you care should have usable std::filesystem

@eagleoflqj eagleoflqj closed this Nov 18, 2024
@eagleoflqj eagleoflqj reopened this Nov 18, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
tools/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@wengxt wengxt merged commit 003f74d into fcitx:master Nov 18, 2024
4 checks passed
@eagleoflqj eagleoflqj deleted the filesystem branch November 18, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants