-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make boost::filesystem optional #81
Conversation
boost filesystem is suppose to be optional if std::filesystem is available. There might be some issue on the GNUC <= 8 condition when build against clang, can you help fix that instead? basically, libstdc++ in gcc 7 doesn't have usable std::filesystem |
Wouldn't it be preferable to remove migration tools? After all fcitx4 was archived, and old versions of libime can always do the one-time job. |
Well, some people may have random binary files available on internet so it could still be useful. I have no plan to remove them anytime soon. |
If you need an example on std::filesystem detection, here's something I found on internet https://github.com/ccache/ccache/pull/1190/files |
Basically what in my mind is, run a CheckCXXSourceCompiles against the API that we use (there's only one), if fail, then fallback to boost filesytem. I believe whatever you care should have usable std::filesystem |
Intent: on macOS enable tools but exclude migrators; on iOS disable them all.