Readme: Fixing it #646
Merged
Readme: Fixing it #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunefro
suggested changes
Apr 27, 2022
README.md
Outdated
| # Compare it | ||
| diff kitty.jpg kitty2.jpg | ||
| # Starting the sample FTP server | ||
| docker run --rm -d -p 2121-2130:2121-2130 -v $(pwd):/app fclairamb/ftpserver |
There was a problem hiding this comment.
Any reason for not including the /tmp path to the files directory you created above.
To make the data persistent
docker run --rm -d -p 2121-2130:2121-2130 -v $(pwd)/files:/tmp -v $(pwd):/app fclairamb/ftpserver
Am I missing something in the documentation ?
There was a problem hiding this comment.
Well, I hesitated and left the files directory and dropped the -v $(pwd)/files:/tmp... Because /tmp is not the smartest path for persistence 😬 and I would like to keep the local & docker config common for the demo.
But I guess I can keep it that way.
There was a problem hiding this comment.
Yes you are right, /tmp for once is quite ambiguous in certain sense.
Docker sample usage: Binding files directory to /tmp
|
@dunefro good for you now ? |
|
@fclairamb Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #629