Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install rx-flux => not in npm registry #2

Open
pillowsoft opened this issue Dec 12, 2014 · 16 comments
Open

npm install rx-flux => not in npm registry #2

pillowsoft opened this issue Dec 12, 2014 · 16 comments

Comments

@pillowsoft
Copy link

I'd like to try it out, but get this:

npm ERR! 404 'rx-flux' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it

I can of course pull it off github, but figure you might want to get it in the registry. Thanks!!!

@fdecampredon
Copy link
Owner

This library is a work in progress, I should publish it soon on npm, but need to do some extra work before.

@hekike
Copy link

hekike commented Jan 2, 2015

@fdecampredon what do you think, how much time do you need? Can I help with something? I really would like to see it on npm ;)

@fdecampredon
Copy link
Owner

in fact I have a last refactoring scheduled for store :d and I should publish it, it should be ready next week :) sorry for the delay.

@hekike
Copy link

hekike commented Jan 2, 2015

@fdecampredon sounds great! ;)

@jfsiii
Copy link

jfsiii commented Jan 15, 2015

@fdecampredon is 96a60e7 the refactoring you mentioned in #2 (comment)?

@fdecampredon
Copy link
Owner

Yup now I just need to figure how to handle error properly/update doc and the 0.2 should be published on npm, I also just created a 0.1 tag with old store version for those who used it (if there is any)

@hekike
Copy link

hekike commented Jan 15, 2015

@fdecampredon why not follow the proper semver and release 1.0.0?
Btw I mentioned your lib here: http://blog.risingstack.com/flux-inspired-libraries-with-react/ ;)

@fdecampredon
Copy link
Owner

Thank you @hekike.

Yes I'm thinking about it however I'm still not 100% happy with the current implementation.
Here are my concern :

  • Error handling in store :
    • from the initialValue observable
    • in transform function
  • Error handling in action:
    • Should the observable notify error ?
    • Should it rethrows the error ?
  • Where data validation should be done:
    • Inside actions ?
    • inside the react component ?

Also I'm thinking about a way to define action inspired by https://github.com/staltz/cycle (see the actual todomvc example). But I'm not so happy with the result :/.

Finally while I like my operation system on store, and how it allows to be reverted (for smooth integration with remote async call), I'm still not 100% happy with the result, I'm thinking about a possibility to directly listen 'actions' on a node server (yes it might seems crazy but it has some logic from a reactive point of view) but I think it would need to be done in a separate project.

Until all those concerns are cleared I'll publish only 0.x the 0.2 is scheduled soon, I just want to handle error properly. By the way if any of you have feedbacks/comments It could help me in my reflexion

@ivanoats
Copy link

I'd like to see an 0.x soon please, because:

  1. The examples depend on it in npm
  2. I'd like to start using this and potentially contributing. I think it's great! Thanks for putting this together.

@BerkeleyTrue
Copy link

How about adding onError property to the store definition and having it handle both operation errors.

@fdecampredon
Copy link
Owner

OK since there seems to be some bunch of people really interested in rx-flux I'm quite happy, however I feel sorry and I must apologize, because I didn't had much time to work on it until now.
Now I want to resume my work on that one and I won't switch to any other side projects until I have designed the right api for this one and published it on npm, rest assured.

However I think I had some good idea here and I think this project deserves the right api before being published, If any of you want to help me please go see #10

@zbyte64
Copy link

zbyte64 commented Mar 2, 2015

👍

1 similar comment
@simonexmachina
Copy link

👍

@SupremeTechnopriest
Copy link
Collaborator

@fdecampredon let me know if I can be of any service to you. For anyone who needs the latest npm module, I published under my own namespace. npm install @supremetechnopriest/rx-flux you can use that in the mean time while @fdecampredon and I get this library production ready.

@fdecampredon
Copy link
Owner

I believe that rx-flux offer no advantage over @gaearon https://github.com/rackt/redux, and I clearly encourage you to use it instead of this project.
I won't maintain it, anyway it always have been more an experiment than anything (that's mainly why I never published it to npm).

@fdecampredon
Copy link
Owner

SupremeTechnopriest I gave you the right over the project, if you wish to maintain it feel free !
Feel also free to ask for any advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants