-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display-first as an opt-in alternative handling of recent characters #78
Conversation
…ing recents to 10
Sorry to leave this uncommented for so long, and thanks for your patience! 🙏 I used some of that break to think about this issue, and I think I found some good starting points. So, to recap first, the problems with this approach are:
Now, a possible solution, or at least a start: Orthogonal to that, if one wants to make skin-tone selection easier, we could save "built" emojis (i.e. ones with skin tones) separately and suggest those in the skin tone selection dialog. I'm not really sure about the UX here; if it is more comfortable or not, but it's something to think about. However, I think the first idea could solve the problems we have here. What is your opinion? Would you want to try that out? Should I do so, whenever I find time? |
So, I have finally found the time to try this and I have to admit, I like it so far. Speed is also not a problem (yet 🙈). Please try out the |
Sorry for the delay, I've been a bit busy lately. I've had a look at The only reason I would argue for most-recently-used over frecency is that frecency is somewhat unpredictable (it's easier to mentally predict MRU than frecency sorting). However, frecency ordering does get a bit more stable with usage and the I can't really share much insight into multi-character selection / skintone character handling as I don't use those very often but the way you've done it seems reasonable. Overall, I quite like how this works. Thanks for taking the time to look into this! Are you planning on releasing the frecent version? |
No worries 🙂
Yes, and I'd even say that frecency gets more predictable than least-recently-used after some time, as each usage has less and less impact.
Thanks. I do hope it's better to use, but as always, I'm eager to hear feedback 🙂
You're welcome, and thanks for your effort and for pushing me to investigate the whole idea deeper! I had plans for this even back when I first started
I'd like to, but I was waiting for feedback first, if people like the change, if it improves something or if I broke it. Maybe I'll merge it soon and see what happens then 😉 |
This PR adds a
--display-recents {bar,display-first}
option, defaulting tobar
(current behaviour).When set to
display-first
, recent characters are displayed as initial entries of the character list rather than on a separate bar. Recent characters can still be inserted using thealt+n
keybinding, but there will be no visual indication as to which recent character corresponds to which number.See previous discussion at #74