Skip to content

Commit

Permalink
Removed unnecessary "sources" in Python SDK unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
woop committed Nov 19, 2019
1 parent a75116c commit 2d8cc6f
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions sdk/python/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,11 +367,6 @@ def test_feature_set_ingest_success(self, dataframe, client, mocker):
driver_fs.add(Feature(name="feature_3", dtype=ValueType.INT64))
driver_fs.add(Entity(name="entity_id", dtype=ValueType.INT64))

driver_fs.source = KafkaSource(topic="feature-topic", brokers="127.0.0.1")

client._message_producer = MagicMock()
client._message_producer.produce = MagicMock()

# Register with Feast core
client.apply(driver_fs)

Expand All @@ -397,11 +392,6 @@ def test_feature_set_ingest_failure(self, client, dataframe, exception):
with pytest.raises(exception):
# Create feature set
driver_fs = FeatureSet("driver-feature-set")
driver_fs.source = KafkaSource(
topic="feature-topic", brokers="fake.broker.com"
)
client._message_producer = MagicMock()
client._message_producer.produce = MagicMock()

# Update based on dataset
driver_fs.infer_fields_from_df(dataframe)
Expand Down Expand Up @@ -437,10 +427,6 @@ def test_feature_set_types_success(self, client, dataframe, mocker):
max_age=Duration(seconds=3600),
)

all_types_fs.source = KafkaSource(topic="feature-topic", brokers="127.0.0.1")
client._message_producer = MagicMock()
client._message_producer.produce = MagicMock()

# Register with Feast core
client.apply(all_types_fs)

Expand Down

0 comments on commit 2d8cc6f

Please sign in to comment.