Skip to content

Commit

Permalink
feat: Make feast PEP 561 compliant (#2405)
Browse files Browse the repository at this point in the history 
* add py.typed marker

Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* add py.typed to MANIFEST.in

Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* ignore mypy error from generated protos modules

Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* revert: ignore mypy error from generated protos modules

Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* reorder imports

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* sort imports

Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* sort imports

Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* feat: Allow using entity's join_key in get_online_features (#2420)

* allowing using entity's join_key in get_online_features

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* fix tests

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* fix!: GetOnlineFeatureResponse in Python feature server should be consisten… (#2418)

* GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* fix local e2e test

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* reuse timestamp in response generation

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* chore: Adding documentation on community calendar + newsletter + updating CONTRIBUTING.md (#2425)

* chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix PR template

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix PR template

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* feat: Graduate write_to_online_store out of experimental status (#2426)

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* refactor!: Remove deprecated parameters from Entity and FeatureView (#2427)

* Remove labels parameter from Entity

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Remove input parameter and deprecate Duration type for ttl parameter in FeatureView

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Change examples to stop using Duration

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Delete unused example feature repo

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Format

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* ci: Modify release script to only do minor release for breaking changes (#2431)

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* fix: Ensure that __init__ files exist in proto dirs (#2433)

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* feat: Allow using entity's join_key in get_online_features (#2420)

* allowing using entity's join_key in get_online_features

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* fix tests

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* fix!: GetOnlineFeatureResponse in Python feature server should be consisten… (#2418)

* GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* fix local e2e test

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* reuse timestamp in response generation

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* chore: Adding documentation on community calendar + newsletter + updating CONTRIBUTING.md (#2425)

* chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix PR template

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix PR template

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* feat: Graduate write_to_online_store out of experimental status (#2426)

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* refactor!: Remove deprecated parameters from Entity and FeatureView (#2427)

* Remove labels parameter from Entity

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Remove input parameter and deprecate Duration type for ttl parameter in FeatureView

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Change examples to stop using Duration

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Delete unused example feature repo

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Format

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* ci: Modify release script to only do minor release for breaking changes (#2431)

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

* fix: Ensure that __init__ files exist in proto dirs (#2433)

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>

Co-authored-by: Achal Shah <achals@gmail.com>
Co-authored-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Co-authored-by: Danny Chiao <danny@tecton.ai>
Co-authored-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@tpvasconcelos @achals
@pyalex @adchia @felixwang9817
5 people authored Mar 22, 2022
1 parent e14369d commit 3c41f94
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ format-python:
cd ${ROOT_DIR}/sdk/python; python -m black --target-version py37 feast tests

lint-python:
cd ${ROOT_DIR}/sdk/python; python -m mypy feast/ tests/
cd ${ROOT_DIR}/sdk/python; python -m mypy
cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/ --check-only
cd ${ROOT_DIR}/sdk/python; python -m flake8 feast/ tests/
cd ${ROOT_DIR}/sdk/python; python -m black --check feast tests
Expand Down
1 change: 1 addition & 0 deletions sdk/python/MANIFEST.in
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
recursive-include feast/protos/ *.py
include feast/binaries/*
recursive-include feast py.typed *.pyi
Empty file added sdk/python/feast/py.typed
View file
Empty file.
3 changes: 2 additions & 1 deletion sdk/python/setup.cfg
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[isort]
src_paths = feast,tests
multi_line_output=3
include_trailing_comma=True
force_grid_wrap=0
Expand All @@ -16,5 +17,5 @@ select = B,C,E,F,W,T4
exclude = .git,__pycache__,docs/conf.py,dist,feast/protos

[mypy]
files=feast,test
files=feast,tests
ignore_missing_imports=true

0 comments on commit 3c41f94

Please sign in to comment.