Skip to content

Commit

Permalink
Fix release workflow to pass the python version and docker build targ…
Browse files Browse the repository at this point in the history
…ets (#2122)

* Fix release workflow to pass the python version

Signed-off-by: Danny Chiao <danny@tecton.ai>

* Fix workflows to call right makefiles

Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
adchia authored Dec 8, 2021
1 parent b10c5c4 commit 65c41bd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,4 @@ jobs:
--output-dir .
- name: Build image
run: |
make build-${{ matrix.component }} REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
--output-dir .
- name: Build image
run: |
make build-${{ matrix.component }} REGISTRY=${REGISTRY} VERSION=${RELEASE_VERSION}
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${RELEASE_VERSION}
env:
RELEASE_VERSION: ${{ needs.get-version.outputs.release_version }}
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
Expand All @@ -90,7 +90,7 @@ jobs:
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
HIGHEST_SEMVER_TAG: ${{ needs.get-version.outputs.highest_semver_tag }}
run: |
make push-${{ matrix.component }} REGISTRY=${REGISTRY} VERSION=${RELEASE_VERSION}
make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${RELEASE_VERSION}
echo "Only push to latest tag if tag is the highest semver version $HIGHEST_SEMVER_TAG"
if [ "${VERSION_WITHOUT_PREFIX}" = "${HIGHEST_SEMVER_TAG:1}" ]
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
- name: Install pip-tools
run: pip install pip-tools
- name: Install dependencies
run: make install-python-ci-dependencies
run: make install-python-ci-dependencies PYTHON=3.7
- name: Publish Python Package
run: |
cd sdk/python
Expand Down

0 comments on commit 65c41bd

Please sign in to comment.