Skip to content

Commit

Permalink
fix: Stop running go mod tidy in setup.py
Browse files Browse the repository at this point in the history
Signed-off-by: Achal Shah <achals@gmail.com>

This fixes a problem similar to pypa/cibuildwheel#189 (comment).

Running `go mod tidy` was updating `go.mod` and `go.sum`, which was causeing cibuildwheel to produce dirty builds. This comamnd isn't really even needed, so nixing it.
  • Loading branch information
achals committed Jun 28, 2022
1 parent ba81a31 commit 6716409
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,6 @@ def build_extension(self, ext: Extension):
env={"PATH": bin_path, **go_env})
subprocess.check_call(["go", "install", "github.com/go-python/gopy"],
env={"PATH": bin_path, **go_env})
subprocess.check_call(["go", "mod", "tidy"],
env={"PATH": bin_path, **go_env})
subprocess.check_call(
[
"gopy",
Expand Down

0 comments on commit 6716409

Please sign in to comment.