Skip to content

Commit

Permalink
Refactor configurable options and add sphinx docs (#1174)
Browse files Browse the repository at this point in the history
* Refactor constants and add sphinx docs

Signed-off-by: Terence <terencelimxp@gmail.com>

* Set default jobservice to none

Signed-off-by: Terence <terencelimxp@gmail.com>

* Fix auth tests

Signed-off-by: Terence <terencelimxp@gmail.com>

* Some fixes

Signed-off-by: Terence <terencelimxp@gmail.com>

* Address comments

Signed-off-by: Terence <terencelimxp@gmail.com>

* Address comments

Signed-off-by: Terence <terencelimxp@gmail.com>

* Test none default

Signed-off-by: Terence <terencelimxp@gmail.com>

* Set default as none

Signed-off-by: Terence <terencelimxp@gmail.com>

* Update docs

Signed-off-by: Terence <terencelimxp@gmail.com>

* Cleanup spark launcher constant

Signed-off-by: Terence <terencelimxp@gmail.com>

* Update constants and clarify docstring

Signed-off-by: Terence <terencelimxp@gmail.com>

* Polish docstrings

Signed-off-by: Terence <terencelimxp@gmail.com>
  • Loading branch information
terryyylim authored Nov 19, 2020
1 parent 3b5d30f commit 78cbd13
Show file tree
Hide file tree
Showing 11 changed files with 326 additions and 306 deletions.
9 changes: 8 additions & 1 deletion sdk/python/docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,11 @@ Feature

.. automodule:: feast.feature
:inherited-members:
:members:
:members:

Constants
==================

.. automodule:: feast.constants
:members:
:exclude-members: AuthProvider, ConfigMeta
6 changes: 3 additions & 3 deletions sdk/python/feast/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

from feast.client import Client
from feast.config import Config
from feast.constants import CONFIG_SPARK_LAUNCHER
from feast.constants import ConfigOptions as opt
from feast.entity import Entity
from feast.feature_table import FeatureTable
from feast.job_service import start_job_service
Expand Down Expand Up @@ -422,7 +422,7 @@ def stop_stream_to_online(feature_table: str):
Stop stream to online sync job
"""

spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
spark_launcher = Config().get(opt.SPARK_LAUNCHER)

if spark_launcher == "emr":
import feast.pyspark.aws.jobs
Expand All @@ -441,7 +441,7 @@ def list_jobs():
"""
from tabulate import tabulate

spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
spark_launcher = Config().get(opt.SPARK_LAUNCHER)

if spark_launcher == "emr":
import feast.pyspark.aws.jobs
Expand Down
Loading

0 comments on commit 78cbd13

Please sign in to comment.