Fix tests, update docs, rebase on master

feast-dev · Jun 19, 2020 · 823bd9c · 823bd9c
1 parent 01f1c8c
commit 823bd9c
Show file tree

Hide file tree

Showing 5 changed files with 81 additions and 78 deletions.
diff --git a/docs/user-guide/statistics.md b/docs/user-guide/statistics.md
@@ -160,4 +160,5 @@ The metrics are tagged with and can be aggregated by the following keys:
 | feast\_featureSet\_name | feature set name |
 | feast\_feature\_name | feature name |
 | ingestion\_job\_name | id of the population job writing the feature values. |
+| metrics\_namespace | either `Inflight` or `WriteToStoreSuccess` |
 
diff --git a/...ion/src/test/java/feast/ingestion/transform/metrics/WriteFeatureValueMetricsDoFnTest.java b/...ion/src/test/java/feast/ingestion/transform/metrics/WriteFeatureValueMetricsDoFnTest.java
@@ -77,6 +77,7 @@ public void shouldSendCorrectStatsDMetrics() throws IOException, InterruptedExce
                     .setStatsdHost("localhost")
                     .setStatsdPort(STATSD_SERVER_PORT)
                     .setStoreName("store")
+                    .setMetricsNamespace("test")
                     .build()));
     pipeline.run(pipelineOptions).waitUntilFinish();
     // Wait until StatsD has finished processed all messages, 3 sec is a reasonable duration

diff --git a/ingestion/src/test/java/feast/ingestion/transform/metrics/WriteRowMetricsDoFnTest.java b/ingestion/src/test/java/feast/ingestion/transform/metrics/WriteRowMetricsDoFnTest.java
@@ -60,6 +60,7 @@ public void shouldSendCorrectStatsDMetrics() throws IOException, InterruptedExce
                     .setStatsdPort(STATSD_SERVER_PORT)
                     .setStoreName("store")
                     .setClock(Clock.fixed(Instant.ofEpochSecond(1585548645), ZoneId.of("UTC")))
+                    .setMetricsNamespace("test")
                     .build()));
     pipeline.run(pipelineOptions).waitUntilFinish();
     // Wait until StatsD has finished processed all messages, 3 sec is a reasonable duration