Skip to content

Commit

Permalink
fix: Protobuf lower bound to 3.20 to alert that Feast is incompatible…
Browse files Browse the repository at this point in the history
… with tensorflow (#3476)

* build: protobuf lower bound to 3.20

Signed-off-by: gbmarc1 <marcantoine.belanger@shopify.com>

* lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

---------

Signed-off-by: gbmarc1 <marcantoine.belanger@shopify.com>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Co-authored-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
gbmarc1 and adchia authored Feb 17, 2023
1 parent 2c85421 commit 9ca59e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/bigquery_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def get_table_column_names_and_types(
from google.api_core import client_info as http_client_info
except ImportError as e:
from feast.errors import FeastExtrasDependencyImportError

raise FeastExtrasDependencyImportError("gcp", str(e))

from google.cloud import bigquery
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"numpy>=1.22,<3",
"pandas>=1.4.3,<2",
"pandavro~=1.5.0", # For some reason pandavro higher than 1.5.* only support pandas less than 1.3.
"protobuf<5,>3",
"protobuf<5,>3.20",
"proto-plus>=1.20.0,<2",
"pyarrow>=4,<9",
"pydantic>=1,<2",
Expand Down

0 comments on commit 9ca59e3

Please sign in to comment.