Skip to content

Commit

Permalink
fix: Trying to import pyspark lazily to avoid the dependency on the l…
Browse files Browse the repository at this point in the history
…ibrary (#4091)
  • Loading branch information
lokeshrangineni authored Apr 15, 2024
1 parent ec19036 commit a05cdbc
Showing 1 changed file with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
from enum import Enum
from typing import Any, Callable, Dict, Iterable, Optional, Tuple

from pyspark.sql import SparkSession

from feast import flags_helper
from feast.data_source import DataSource
from feast.errors import DataSourceNoNameException, DataSourceNotFoundException
Expand Down Expand Up @@ -162,6 +160,13 @@ def get_table_column_names_and_types(

def get_table_query_string(self) -> str:
"""Returns a string that can directly be used to reference this table in SQL"""
try:
from pyspark.sql import SparkSession
except ImportError as e:
from feast.errors import FeastExtrasDependencyImportError

raise FeastExtrasDependencyImportError("spark", str(e))

if self.table:
# Backticks make sure that spark sql knows this a table reference.
table = ".".join([f"`{x}`" for x in self.table.split(".")])
Expand Down

0 comments on commit a05cdbc

Please sign in to comment.