Add loadBalancerSourceRanges option for both serving and core (#114)

feast-dev · Jan 29, 2019 · a73195a · a73195a
1 parent f6d0c79
commit a73195a
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 5 deletions.
diff --git a/charts/README.md b/charts/README.md
@@ -73,7 +73,8 @@ The following table lists the configurable parameters of the Feast chart and the
 | `core.resources.limits.memory` | core memory limits | 2G |
 | `core.resources.requests.cpu` | core cpu requested | 1 |
 | `core.resources.requests.memory` | core memory requested | 2G |
-| `core.service.extIPAdr` | external IP address for core, required so jobs on external runners can connect to core | nil | 
+| `core.service.extIPAdr` | Internal load balancer IP Address for core, required so jobs on external runners can connect to core | nil | 
+| `core.service.loadBalancerSourceRanges` | IP source ranges that will have access to core. If not set, will default to 0.0.0.0/0 | nil | 
 | `core.service.grpc.port` | core service exposed grpc port | 8433 |
 | `core.service.grpc.targetPort` | core service target grpc port | 8433 |
 | `core.service.http.port` | core service exposed http port | 80 |
@@ -101,6 +102,8 @@ The following table lists the configurable parameters of the Feast chart and the
 | `serving.service.grpc.targetPort` | serving service target grpc port | 8433 |
 | `serving.service.http.port` | serving service exposed http port | 80 |
 | `serving.service.http.targetPort` | serving service target http port | 8080 |
+| `serving.service.extIPAdr` | Internal load balancer IP Address for serving, required so jobs on external runners can connect to the service | nil | 
+| `serving.service.loadBalancerSourceRanges` | IP source ranges that will have access to serving. If not set, will default to 0.0.0.0/0 | nil |
 | `serviceAccount.name` | service account secret name to mount to deployments | nil | 
 | `serviceAccount.key` | service account secret key to mount to deployments | nil | 
 | `statsd.host` | host of statsd daemon for job metrics to be sent to | nil | 

diff --git a/charts/dist/feast-0.1.0.tgz b/charts/dist/feast-0.1.0.tgz
diff --git a/charts/dist/index.yaml b/charts/dist/index.yaml
@@ -3,11 +3,11 @@ entries:
   feast:
   - apiVersion: v1
     appVersion: 0.1.0
-    created: 2019-01-23T15:59:57.223680331+08:00
+    created: 2019-01-29T17:38:41.064665659+08:00
     description: A Helm chart to install Feast on kubernetes
-    digest: 1b392c4fa1e3b7cff7afb1dc635a248d86c0c05d8b02b6fc4e884c20f6a03ff2
+    digest: 099023ae667dd8129fbf72adf14732cf1f32af60784d694634ef4e1983957a5a
     name: feast
     urls:
     - feast-0.1.0.tgz
     version: 0.1.0
-generated: 2019-01-23T15:59:57.222635289+08:00
+generated: 2019-01-29T17:38:41.063588825+08:00
diff --git a/charts/feast/templates/core-service.yaml b/charts/feast/templates/core-service.yaml
@@ -14,6 +14,12 @@ spec:
   type: LoadBalancer
   {{- if .Values.core.service.extIPAdr }}
   loadBalancerIP: {{ .Values.core.service.extIPAdr }}
+  {{- if .Values.core.service.loadBalancerSourceRanges }}
+  loadBalancerSourceRanges:
+  {{- range .Values.core.service.loadBalancerSourceRanges }}
+  - {{ . }}
+  {{- end }}
+  {{- end }}
   {{- end }}
   ports:
   - name: http

diff --git a/charts/feast/templates/serving-service.yaml b/charts/feast/templates/serving-service.yaml
@@ -14,7 +14,13 @@ spec:
   type: LoadBalancer
   {{- if .Values.serving.service.extIPAdr }}
   loadBalancerIP: {{ .Values.serving.service.extIPAdr }}
-  {{- end}}
+  {{- if .Values.serving.service.loadBalancerSourceRanges }}
+  loadBalancerSourceRanges:
+  {{- range .Values.serving.service.loadBalancerSourceRanges }}
+  - {{ . }}
+  {{- end }}
+  {{- end }}
+  {{- end }}
   ports:
   - name: grpc
     port: {{ .Values.serving.service.grpc.port }}