Clean up FeatureService

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

protos/feast/core/FeatureService.proto

@@ -32,6 +32,9 @@ message FeatureServiceSpec {
 
   // Description of the feature service.
   string description = 5;
+
+  // Owner of the feature service.
+  string owner = 6;
 }
 
 

sdk/python/feast/feature_service.py

@@ -19,21 +19,25 @@
 
 class FeatureService:
     """
-    A feature service is a logical grouping of features for retrieval (training or serving).
-    The features grouped by a feature service may come from any number of feature views.
-
-    Args:
-        name: Unique name of the feature service.
-        features: A list of Features that are grouped as part of this FeatureService.
-            The list may contain Feature Views, Feature Tables, or a subset of either.
-        tags (optional): A dictionary of key-value pairs used for organizing Feature
-            Services.
+    A feature service defines a logical group of features from one or more feature views.
+    This group of features can be retrieved together during training or serving.
+
+    Attributes:
+        name: The unique name of the feature service.
+        feature_view_projections: A list containing feature views and feature view
+            projections, representing the features in the feature service.
+        description: A human-readable description.
+        tags: A dictionary of key-value pairs to store arbitrary metadata.
+        owner: The owner of the feature service.
+        created_timestamp: The time when the feature service was created.
+        last_updated_timestamp: The time when the feature service was last updated.
     """
 
     _name: str
     _feature_view_projections: List[FeatureViewProjection]
+    _description: str
     _tags: Dict[str, str]
-    _description: Optional[str] = None
+    _owner: str
     _created_timestamp: Optional[datetime] = None
     _last_updated_timestamp: Optional[datetime] = None
 
@@ -42,8 +46,9 @@ def __init__(
         self,
         name: str,
         features: List[Union[FeatureView, OnDemandFeatureView]],
-        tags: Optional[Dict[str, str]] = None,
-        description: Optional[str] = None,
+        tags: Dict[str, str] = None,
+        description: str = "",
+        owner: str = "",
     ):
         """
         Creates a FeatureService object.
@@ -59,12 +64,13 @@ def __init__(
                 self._feature_view_projections.append(feature_grouping.projection)
             else:
                 raise ValueError(
-                    "The FeatureService {fs_name} has been provided with an invalid type"
+                    f"The feature service {name} has been provided with an invalid type "
                     f'{type(feature_grouping)} as part of the "features" argument.)'
                 )
 
-        self._tags = tags or {}
         self._description = description
+        self._tags = tags or {}
+        self._owner = owner
         self._created_timestamp = None
         self._last_updated_timestamp = None
 
@@ -83,7 +89,13 @@ def __eq__(self, other):
             raise TypeError(
                 "Comparisons should only involve FeatureService class objects."
             )
-        if self.tags != other.tags or self.name != other.name:
+
+        if (
+            self.name != other.name
+            or self.description != other.description
+            or self.tags != other.tags
+            or self.owner != other.owner
+        ):
             return False
 
         if sorted(self.feature_view_projections) != sorted(
@@ -111,6 +123,14 @@ def feature_view_projections(
     ):
         self._feature_view_projections = feature_view_projections
 
+    @property
+    def description(self) -> str:
+        return self._description
+
+    @description.setter
+    def description(self, description: str):
+        self._description = description
+
     @property
     def tags(self) -> Dict[str, str]:
         return self._tags
@@ -120,12 +140,12 @@ def tags(self, tags: Dict[str, str]):
         self._tags = tags
 
     @property
-    def description(self) -> Optional[str]:
-        return self._description
+    def owner(self) -> str:
+        return self._owner
 
-    @description.setter
-    def description(self, description: str):
-        self._description = description
+    @owner.setter
+    def owner(self, owner: str):
+        self._owner = owner
 
     @property
     def created_timestamp(self) -> Optional[datetime]:
@@ -155,11 +175,8 @@ def from_proto(feature_service_proto: FeatureServiceProto):
             name=feature_service_proto.spec.name,
             features=[],
             tags=dict(feature_service_proto.spec.tags),
-            description=(
-                feature_service_proto.spec.description
-                if feature_service_proto.spec.description != ""
-                else None
-            ),
+            description=feature_service_proto.spec.description,
+            owner=feature_service_proto.spec.owner,
         )
         fs.feature_view_projections.extend(
             [
@@ -181,29 +198,28 @@ def from_proto(feature_service_proto: FeatureServiceProto):
 
     def to_proto(self) -> FeatureServiceProto:
         """
-        Converts a FeatureService to its protobuf representation.
+        Converts a feature service to its protobuf representation.
 
         Returns:
             A FeatureServiceProto protobuf.
         """
         meta = FeatureServiceMeta()
         if self.created_timestamp:
             meta.created_timestamp.FromDatetime(self.created_timestamp)
+        if self.last_updated_timestamp:
+            meta.last_updated_timestamp.FromDatetime(self.last_updated_timestamp)
 
         spec = FeatureServiceSpec(
             name=self.name,
             features=[
                 projection.to_proto() for projection in self.feature_view_projections
             ],
+            tags=self.tags,
+            description=self.description,
+            owner=self.owner,
         )
 
-        if self.tags:
-            spec.tags.update(self.tags)
-        if self.description:
-            spec.description = self.description
-
-        feature_service_proto = FeatureServiceProto(spec=spec, meta=meta)
-        return feature_service_proto
+        return FeatureServiceProto(spec=spec, meta=meta)
 
     def validate(self):
         pass