Skip to content

Commit

Permalink
fix: Helm chart feast-feature-server, improve Service template name (
Browse files Browse the repository at this point in the history
…#4161)

fix: feast-feature-server helm chart's Service template

Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
tchughesiv committed May 1, 2024
1 parent 4a696dc commit dedc164
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions examples/python-helm-demo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ We use the Feast CLI to register and materialize features, and then retrieving v
3. `helm install feast-release ../../../infra/charts/feast-feature-server --set image.tag=dev --set feature_store_yaml_base64=$(base64 feature_store.yaml)`
5. (Optional): check logs of the server to make sure it’s working
```bash
kubectl logs svc/feast-feature-server
kubectl logs svc/feast-release-feast-feature-server
```
6. Port forward to expose the grpc endpoint:
```bash
kubectl port-forward svc/feast-feature-server 6566:80
kubectl port-forward svc/feast-release-feast-feature-server 6566:80
```
7. Run test fetches for online features:8.
- First: change back the Redis connection string to allow localhost connections to Redis
Expand Down
2 changes: 1 addition & 1 deletion infra/charts/feast-feature-server/templates/service.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: Service
metadata:
name: {{ include "feast-feature-server.name" . }}
name: {{ include "feast-feature-server.fullname" . }}
labels:
{{- include "feast-feature-server.labels" . | nindent 4 }}
spec:
Expand Down

0 comments on commit dedc164

Please sign in to comment.