Skip to content

Commit

Permalink
Fix bug causing OnDemandFeatureView.infer_features() to fail when the…
Browse files Browse the repository at this point in the history
…re are labels present in the features that are registered in the on-deamnd-feature-view definition.

Signed-off-by: ArrichM <maximilianjakob.arrich@student.unisg.ch>
  • Loading branch information
ArrichM committed Nov 16, 2021
1 parent dc46a96 commit e1017ac
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sdk/python/feast/on_demand_feature_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ def infer_features(self):

if self.features:
missing_features = []
for specified_features in self.features:
delabeled_features = [Feature(name=f.name, dtype=f.dtype) for f in self.features]
for specified_features in delabeled_features:
if specified_features not in inferred_features:
missing_features.append(specified_features)
if missing_features:
Expand Down

0 comments on commit e1017ac

Please sign in to comment.