Skip to content

Commit

Permalink
Set protobuf version, add kafka client for testing
Browse files Browse the repository at this point in the history
  • Loading branch information
zhilingc committed Oct 22, 2019
1 parent c839b9f commit e1e7815
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions ingestion/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,12 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>${protobufVersion}</version>

This comment has been minimized.

Sign in to view

Copy link
@ches

ches Oct 22, 2019

Member

This should not be set/repeated in subproject POMs for use with <dependencyManagement> since #262—the goal of that is to avoid versions drifting between modules which is probably not a good idea in the long run, especially for dependencies so integral to the whole dep tree.

kafka-clients also has version set in the top-level pom.xml, although it might not have been used anymore since yesterday removal of its direct use in production code was merged. So you could leave out the <version> for that here too and just leave the <scope> specification.

I think that maven-enforcer-plugin can check that we avoid re-declaring dependencies, to make this intent clear and understood. I'll check about sending a PR to enable that.
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java-util</artifactId>
<version>${protobufVersion}</version>
</dependency>

<dependency>
Expand All @@ -197,6 +199,13 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
<version>2.3.0</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>joda-time</groupId>
<artifactId>joda-time</artifactId>
Expand Down

0 comments on commit e1e7815

Please sign in to comment.