support redis ssl in feast-serving (#1092)

* support redis ssl in feast-serving Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
feast-dev · Oct 23, 2020 · e426ab8 · e426ab8
1 parent c05d3d7
commit e426ab8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/infra/terraform/aws/helm.tf b/infra/terraform/aws/helm.tf
@@ -62,6 +62,7 @@ locals {
               config = {
                 host = module.redis.endpoint
                 port = 6379
+                ssl  = true
               }
               subscriptions = [
                 {

diff --git a/protos/feast/core/Store.proto b/protos/feast/core/Store.proto
@@ -110,6 +110,8 @@ message Store {
     int32 max_retries = 4;
     // Optional. How often flush data to redis
     int32 flush_frequency_seconds = 5;
+    // Optional. Connect over SSL.
+    bool ssl = 6;
   }
 
   message BigQueryConfig {

diff --git a/sdk/python/requirements-ci.txt b/sdk/python/requirements-ci.txt
@@ -18,4 +18,5 @@ mypy
 mypy-protobuf
 avro==1.10.0
 confluent_kafka
-gcsfs
+gcsfs
+urllib3>=1.25.4
diff --git a/.../connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisClient.java b/.../connectors/redis/src/main/java/feast/storage/connectors/redis/retriever/RedisClient.java
@@ -47,10 +47,14 @@ private RedisClient(StatefulRedisConnection<byte[], byte[]> connection) {
   }
 
   public static RedisClientAdapter create(Map<String, String> config) {
+
+    RedisURI uri = RedisURI.create(config.get("host"), Integer.parseInt(config.get("port")));
+
+    if (Boolean.parseBoolean(config.get("ssl"))) {
+      uri.setSsl(true);
+    }
     StatefulRedisConnection<byte[], byte[]> connection =
-        io.lettuce.core.RedisClient.create(
-                RedisURI.create(config.get("host"), Integer.parseInt(config.get("port"))))
-            .connect(new ByteArrayCodec());
+        io.lettuce.core.RedisClient.create(uri).connect(new ByteArrayCodec());
 
     return new RedisClient(connection);
   }