revert removing ge

Signed-off-by: Danny Chiao <danny@tecton.ai>
feast-dev · Mar 6, 2022 · f8579a9 · f8579a9
1 parent 6cbdeda
commit f8579a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -42,7 +42,6 @@
 from feast.data_source import DataSource
 from feast.diff.infra_diff import InfraDiff, diff_infra_protos
 from feast.diff.registry_diff import RegistryDiff, apply_diff_to_registry, diff_between
-from feast.dqm.profilers.ge_profiler import GEProfiler
 from feast.entity import Entity
 from feast.errors import (
     EntityNotFoundException,
@@ -881,7 +880,6 @@ def create_saved_dataset(
         storage: SavedDatasetStorage,
         tags: Optional[Dict[str, str]] = None,
         feature_service: Optional[FeatureService] = None,
-        profiler: Optional[GEProfiler] = None,
     ) -> SavedDataset:
         """
             Execute provided retrieval job and persist its outcome in given storage.

diff --git a/sdk/python/setup.py b/sdk/python/setup.py
@@ -46,7 +46,6 @@
     "fastavro>=1.1.0",
     "google-api-core>=1.23.0",
     "googleapis-common-protos==1.52.*",
-    "great_expectations>=0.14.0,<0.15.0",
     "grpcio>=1.34.0",
     "grpcio-reflection>=1.34.0",
     "Jinja2>=2.0.0",
@@ -97,6 +96,10 @@
     "pyspark>=3.0.0",
 ]
 
+GE_REQUIRED = [
+    "great_expectations>=0.14.0,<0.15.0"
+]
+
 CI_REQUIRED = (
         [
         "cryptography==3.3.2",
@@ -143,6 +146,7 @@
         + AWS_REQUIRED
         + SNOWFLAKE_REQUIRED
         + SPARK_REQUIRED
+        + GE_REQUIRED
 )
 
 DEV_REQUIRED = ["mypy-protobuf>=3.1.0", "grpcio-testing==1.*"] + CI_REQUIRED
@@ -246,6 +250,7 @@ def run(self):
         "redis": REDIS_REQUIRED,
         "snowflake": SNOWFLAKE_REQUIRED,
         "spark": SPARK_REQUIRED,
+        "ge": GE_REQUIRED,
     },
     include_package_data=True,
     license="Apache",