Skip to content

Commit

Permalink
offline store init doesnt make sense
Browse files Browse the repository at this point in the history
Signed-off-by: Rob Howley <howley.robert@gmail.com>
  • Loading branch information
robhowley committed Oct 23, 2024
1 parent 4eeeda0 commit f85b78f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions sdk/python/feast/infra/offline_stores/offline_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,3 @@ def get_table_column_names_and_types_from_data_source(
data_source: DataSource object
"""
return data_source.get_table_column_names_and_types(config=config)

async def initialize(self, config: RepoConfig) -> None:
pass

async def close(self) -> None:
pass
2 changes: 0 additions & 2 deletions sdk/python/feast/infra/passthrough_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -521,8 +521,6 @@ def get_table_column_names_and_types_from_data_source(

async def initialize(self, config: RepoConfig) -> None:
await self.online_store.initialize(config)
await self.offline_store.initialize(config)

async def close(self) -> None:
await self.online_store.close()
await self.offline_store.close()

0 comments on commit f85b78f

Please sign in to comment.