Add ids for pytest params

Signed-off-by: Achal Shah <achals@gmail.com>
feast-dev · Sep 1, 2021 · ff1fb81 · ff1fb81
1 parent 6c10502
commit ff1fb81
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/sdk/python/tests/conftest.py b/sdk/python/tests/conftest.py
@@ -99,7 +99,9 @@ def simple_dataset_2() -> pd.DataFrame:
     return pd.DataFrame.from_dict(data)
 
 
-@pytest.fixture(params=FULL_REPO_CONFIGS, scope="session")
+@pytest.fixture(
+    params=FULL_REPO_CONFIGS, scope="session", ids=[str(c) for c in FULL_REPO_CONFIGS]
+)
 def environment(request):
     with construct_test_environment(request.param) as e:
         yield e
@@ -130,3 +132,9 @@ def e2e_data_sources(environment: Environment):
     yield df, data_source
 
     environment.data_source_creator.teardown()
+
+
+@pytest.fixture(params=FULL_REPO_CONFIGS, scope="session")
+def type_test_environment(request):
+    with construct_test_environment(request.param) as e:
+        yield e
diff --git a/sdk/python/tests/integration/registration/test_universal_types.py b/sdk/python/tests/integration/registration/test_universal_types.py
@@ -33,7 +33,6 @@ def entity_feature_types_ids(entity_type: ValueType, feature_dtype: str):
     offline_store_creator=BigQueryDataSourceCreator,
     online_store="datastore",
 )
-feature_is_list = [True, False]
 
 
 # TODO: change parametrization to allow for other providers aside from gcp