Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODFVs don't respect full_feature_names #2143

Closed
judahrand opened this issue Dec 14, 2021 · 0 comments · Fixed by #2144
Closed

ODFVs don't respect full_feature_names #2143

judahrand opened this issue Dec 14, 2021 · 0 comments · Fixed by #2144
Assignees
@judahrand
Labels
priority/p1

Comments

@judahrand
Copy link
Member

judahrand commented Dec 14, 2021 •
edited
Loading

Expected Behavior

The dataframe returned by to_df should contain all column names in the format {feature_view_name}__{feature_name}. This should also apply for to_arrow.

The behavior is as expected for get_online_features() but not get_historical_features.

Current Behavior

On-Demand Feature View based features are return as {feature_name} regardless.

Steps to reproduce

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judahrand judahrand

Labels
priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect full_feature_names for ODFVs judahrand/feast
2 participants
@judahrand @felixwang9817