Respect full_feature_names for ODFVs

[judahrand]

Signed-off-by: Judah Rand 17158624+judahrand@users.noreply.github.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2143

Does this PR introduce a user-facing change?:

Respect `full_feature_names` for ODFVs in `get_historical_features`.

[feast-ci-bot]

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[judahrand]

AWS API failing 😢

[felixwang9817]

/lgtm

[felixwang9817]

integration tests are failing (finally!) not due to AWS but an actual bug

pretty sure the bug is line 389: you're referencing "conv_rate_plus_100_rounded" directly, when you should be wrapping it with response_feature_name

[judahrand]

integration tests are failing (finally!) not due to AWS but an actual bug

pretty sure the bug is line 389: you're referencing "conv_rate_plus_100_rounded" directly, when you should be wrapping it with response_feature_name

You're right, missed those! Seems to be passing now! 🥳

[felixwang9817]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment