Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Test-containers spin up DynamoDB for local integration tests. #2505

Closed
TremaMiguel opened this issue Apr 6, 2022 · 0 comments · Fixed by #2531
Closed

ci: Test-containers spin up DynamoDB for local integration tests. #2505

TremaMiguel opened this issue Apr 6, 2022 · 0 comments · Fixed by #2531
Assignees
@felixwang9817
Labels
good first issue Good for newcomers kind/feature New feature or request

Comments

@TremaMiguel
Copy link
Member

Is your feature request related to a problem? Please describe.

Running a local DynamoDB allows to run local integration tests for DynamoDBOnlineStore. As suggested by @achals this can be done via testcontainers.

Describe the solution you'd like

Develop an DynamoDBOnlineStoreCreator like the Redis example of #2493.

Describe alternatives you've considered

Guidelines in Contributing.md so that user manage by its own the Docker Container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixwang9817 felixwang9817

Labels
good first issue Good for newcomers kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Use testcontainers to spin up DynamoDB instances for local integration tests TremaMiguel/feast
3 participants
@achals @felixwang9817 @TremaMiguel