-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use testcontainers to spin up redis and datastore instances #2493
ci: Use testcontainers to spin up redis and datastore instances #2493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2493 +/- ##
===========================================
+ Coverage 58.97% 84.32% +25.35%
===========================================
Files 129 134 +5
Lines 10987 11155 +168
===========================================
+ Hits 6480 9407 +2927
+ Misses 4507 1748 -2759
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
7575857
to
0f2e6f1
Compare
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
a09cc74
to
9b37133
Compare
sdk/python/tests/integration/feature_repos/universal/online_store/redis.py
Outdated
Show resolved
Hide resolved
sdk/python/tests/integration/feature_repos/universal/data_source_creator.py
Show resolved
Hide resolved
sdk/python/tests/integration/feature_repos/repo_configuration.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Running integration tests for contributors has been challenging since they don't always have access to GCP or AWS. This makes development or contributions harder than they need to be.
Additionally, there's some infrastructure that's needed to run tests locally - such as redis. This shouldn't have to be installed by contributors explicitly if it's not necessary.
Which issue(s) this PR fixes:
Fixes #