Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use testcontainers to spin up redis and datastore instances #2493

Merged
merged 12 commits into from
Apr 7, 2022

Conversation

achals
Copy link
Member

@achals achals commented Apr 5, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Running integration tests for contributors has been challenging since they don't always have access to GCP or AWS. This makes development or contributions harder than they need to be.

Additionally, there's some infrastructure that's needed to run tests locally - such as redis. This shouldn't have to be installed by contributors explicitly if it's not necessary.

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #2493 (b8c0936) into master (6abae16) will increase coverage by 25.35%.
The diff coverage is 57.77%.

@@             Coverage Diff             @@
##           master    #2493       +/-   ##
===========================================
+ Coverage   58.97%   84.32%   +25.35%     
===========================================
  Files         129      134        +5     
  Lines       10987    11155      +168     
===========================================
+ Hits         6480     9407     +2927     
+ Misses       4507     1748     -2759     
Flag Coverage Δ
integrationtests 74.40% <58.42%> (?)
unittests 58.87% <45.55%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...niversal/data_sources/spark_data_source_creator.py 40.42% <0.00%> (ø)
...ts/integration/feature_repos/repo_configuration.py 89.47% <42.10%> (+32.61%) ⬆️
sdk/python/tests/conftest.py 89.39% <50.00%> (+32.25%) ⬆️
.../feature_repos/universal/online_store/datastore.py 50.00% <50.00%> (ø)
...tion/feature_repos/universal/online_store/redis.py 50.00% <50.00%> (ø)
...on/feature_repos/universal/online_store_creator.py 66.66% <66.66%> (ø)
...tion/feature_repos/integration_test_repo_config.py 92.30% <84.61%> (-7.70%) ⬇️
...ion/feature_repos/universal/data_source_creator.py 80.95% <100.00%> (+2.00%) ⬆️
...n/feature_repos/universal/data_sources/bigquery.py 97.87% <100.00%> (+57.44%) ⬆️
...ation/feature_repos/universal/data_sources/file.py 66.66% <100.00%> (+17.33%) ⬆️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abae16...b8c0936. Read the comment docs.

@achals achals force-pushed the achal/redis-test-container branch from 7575857 to 0f2e6f1 Compare April 6, 2022 05:10
achals added 10 commits April 6, 2022 14:21
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals marked this pull request as ready for review April 6, 2022 21:26
@achals achals requested a review from a team as a code owner April 6, 2022 21:26
@achals achals requested review from mavysavydav and removed request for a team April 6, 2022 21:26
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals changed the title ci: Use testcontainers to spin up redis instances for tests ci: Use testcontainers to spin up redis and datastore instances for tests Apr 7, 2022
@achals achals changed the title ci: Use testcontainers to spin up redis and datastore instances for tests ci: Use testcontainers to spin up redis and datastore instances Apr 7, 2022
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit df51b94 into feast-dev:master Apr 7, 2022
@achals achals deleted the achal/redis-test-container branch April 7, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants