fix: Broken Feature Service Link

[nsonntag]

No description provided.

[adchia]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, nsonntag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Base: 67.48% // Head: 58.26% // Decreases project coverage by -9.22% ⚠️

Coverage data is based on head (ceb2dd4) compared to base (ae37b20).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
- Coverage   67.48%   58.26%   -9.23%     
==========================================
  Files         179      210      +31     
  Lines       16370    17701    +1331     
==========================================
- Hits        11048    10314     -734     
- Misses       5322     7387    +2065     

Flag	Coverage Δ
integrationtests	?
unittests	58.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...sts/integration/registration/test_universal_cli.py	20.20% <0.00%> (-79.80%)	⬇️
...ts/integration/offline_store/test_offline_write.py	26.08% <0.00%> (-73.92%)	⬇️
...fline_store/test_universal_historical_retrieval.py	28.75% <0.00%> (-71.25%)	⬇️
...ests/integration/e2e/test_python_feature_server.py	29.50% <0.00%> (-70.50%)	⬇️
...dk/python/tests/integration/e2e/test_validation.py	27.55% <0.00%> (-69.30%)	⬇️
...s/integration/registration/test_universal_types.py	32.25% <0.00%> (-67.75%)	⬇️
sdk/python/feast/infra/online_stores/redis.py	28.39% <0.00%> (-66.67%)	⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py	33.87% <0.00%> (-66.13%)	⬇️
sdk/python/tests/data/data_creator.py	34.78% <0.00%> (-65.22%)	⬇️
...n/tests/integration/registration/test_inference.py	35.71% <0.00%> (-64.29%)	⬇️
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[nsonntag]

@adchia I followed the instructions here to fix sign off. But getting a "ERROR: Permission to feast-dev/feast.git denied" when pushing changes to overwrite the branch. Any ideas?

[achals]

@adchia I followed the instructions here to fix sign off. But getting a "ERROR: Permission to feast-dev/feast.git denied" when pushing changes to overwrite the branch. Any ideas?

@nsonntag it sounds you were trying to push to a branch in the feast repo instead of the patch-1 branch in your fork (https://github.com/nsonntag/feast/tree/patch-1)

[nsonntag]

@adchia @achals thanks I got the sign off issue fixed. Looks like the 'lgtm' label was removed. Would one of you be able to add it back?

[achals]

/lgtm

[nsonntag]

@adchia @achals thanks for the patience on this. I was having a few different issues with sign off and signing the commits. Looks like I have 2 workflows waiting for approval. Only the last one needs to run. I should finally have this all fixed. Also looks like the 'lgtm' label was dropped again.

[adchia]

/lgtm