fix: Handle complex Spark data types in SparkSource #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petra Rebernjak <petra@noom.com>
rebstastic
changed the title
|
/ok-to-test |
Codecov ReportBase: 67.11% // Head: 76.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3154 +/- ##
==========================================
+ Coverage 67.11% 76.13% +9.01%
==========================================
Files 175 211 +36
Lines 15907 17858 +1951
==========================================
+ Hits 10676 13596 +2920
+ Misses 5231 4262 -969
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/assign woop |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, rebstastic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adchia
pushed a commit
that referenced
this pull request
Aug 31, 2022
* Make sure data types are strings Signed-off-by: Petra Rebernjak <petra@noom.com> * Lint Signed-off-by: Petra Rebernjak <petra@noom.com> Signed-off-by: Petra Rebernjak <petra@noom.com>
adchia
pushed a commit
that referenced
this pull request
Sep 8, 2022
## [0.24.1](v0.24.0...v0.24.1) (2022-09-08) ### Bug Fixes * Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([5dba4a3](5dba4a3)) * Fix release workflow ([#3144](#3144)) ([c77a655](c77a655)) * Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([95066ea](95066ea)) * Handle complex Spark data types in SparkSource ([#3154](#3154)) ([0e13573](0e13573))
felixwang9817
pushed a commit
that referenced
this pull request
Sep 20, 2022
# [0.25.0](v0.24.0...v0.25.0) (2022-09-20) ### Bug Fixes * Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082)) * Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20)) * Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630)) * Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25)) * Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5)) * Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9)) * Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971)) * Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b)) * Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf)) * Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca)) * Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018)) * Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9)) * Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff)) ### Features * Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2)) * Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c)) * Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2)) * Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755)) * Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3)) * Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211)) * Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
get_table_column_names_and_typesofSparkSourcereturns non-string data type for complex Spark types.For example, if a feature view contains a feature of type
ArrayType(DoubleType(), False), current implementation would return a dictionary such asWith this fix, the returning data type would be
array<double>.This PR ensures that all Spark types are serialized as strings.
Which issue(s) this PR fixes:
Fixes #