-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for custom grpc dial options in Go SDK #1043
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ankurs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ankurs. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thats weird a Java test failed, I didn't touch anything that might affect it |
/retest |
@woop can you please help me run the tests again ? |
/retest |
@woop looks like this is still not triggered |
Thanks! |
What this PR does / why we need it:
This PR adds support for custom grpc dial options in Go SDK. Currently there is now way for the clients to specify custom grpc.DialOption
Which issue(s) this PR fixes:
Fixes #1042
Does this PR introduce a user-facing change?: