Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for custom grpc dial options in Go SDK #1043

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

ankurs
Copy link
Contributor

@ankurs ankurs commented Oct 13, 2020

What this PR does / why we need it:
This PR adds support for custom grpc dial options in Go SDK. Currently there is now way for the clients to specify custom grpc.DialOption

Which issue(s) this PR fixes:
Fixes #1042

Does this PR introduce a user-facing change?:

Adding support for custom grpc dial options in Go SDK

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankurs
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @ankurs. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Oct 13, 2020

/ok-to-test

@woop woop added the kind/feature New feature or request label Oct 13, 2020
@ankurs
Copy link
Contributor Author

ankurs commented Oct 13, 2020

Thats weird a Java test failed, I didn't touch anything that might affect it

@ankurs
Copy link
Contributor Author

ankurs commented Oct 13, 2020

/retest

@ankurs
Copy link
Contributor Author

ankurs commented Oct 14, 2020

@woop can you please help me run the tests again ?

@woop
Copy link
Member

woop commented Oct 15, 2020

/retest

@ankurs
Copy link
Contributor Author

ankurs commented Oct 23, 2020

@woop looks like this is still not triggered

@woop
Copy link
Member

woop commented Oct 23, 2020

@woop looks like this is still not triggered

@ankurs, my apologies. The test you are looking at is a GitHub action. it should be rerun through the UI. I have just triggered it.

@woop woop merged commit 1b2bcc6 into feast-dev:master Oct 23, 2020
@ankurs
Copy link
Contributor Author

ankurs commented Oct 23, 2020

Thanks!

@ankurs ankurs deleted the fix/go-grpc-dial-option branch November 3, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom grpc dial options in Go SDK
3 participants