Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose for Feast 0.8 #1078

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

khorshuheng
Copy link
Collaborator

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

What this PR does / why we need it:
Current docker compose file is based on Feast 0.7. The docker compose file has been updated for Feast 0.8, with the following changes:

  1. Removal of job controller
  2. Core is no longer dependant on Kafka
  3. Add environmental variables to Feast jupyter service such that the client is automatically configured to use the local spark cluster for historical retrieval job.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@oavdeev
Copy link
Collaborator

oavdeev commented Oct 21, 2020

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 21, 2020
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Oct 21, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit a38177e into feast-dev:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants