Add more explanations to the demo notebook, use local file system instead of GCS by default #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
khorshuheng
force-pushed
the
add-more-description-to-demo-notebook
branch
from
4936ae0
to
134f46b
Compare
…tead of GCS by default Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
add-more-description-to-demo-notebook
branch
from
134f46b
to
986b1bc
Compare
|
/test test-end-to-end-redis-cluster |
pyalex
approved these changes
Oct 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Khor Shu Heng khor.heng@gojek.com
What this PR does / why we need it:
Currently, the demo notebook assumes that the user has access to a GCS bucket, which may or may not be the case. The example has been adapted to use local file system instead, but also provides code snippets that allows the user to easily switch to using GCS to store their feature tables.
Add more instructions as well to make the demo clearer.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: